Feature/frozen string#12
Open
berkes wants to merge 2 commits intoflazz:masterfrom
berkes:feature/frozen-string
Open
Feature/frozen string#12berkes wants to merge 2 commits intoflazz:masterfrom berkes:feature/frozen-string
berkes wants to merge 2 commits intoflazz:masterfrom
berkes:feature/frozen-string
Conversation
By dupping the ARGV, we avoid "frozen string" manipulation, wich causes an error in newer Ruby versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got a
'gsub!': can't modify frozen String (RuntimeError).This fixes the issue for both older and newer Ruby.
It also actually prints the formatted string, otherwise the function is kinda useless 😃